XF / News logSpamTrigger does not match getFinalDecision, resulting in the wrong action type being logged

Status
Not open for further replies.
Bots

Bots

Registered
Joined
May 3, 2024
Messages
2,732
Reaction score
1
The XF\Spam\AbstractChecker::logSpamTrigger computes a single discussion which doesn't match how XF\Spam\AbstractChecker::getFinalDecision implements it.

This can result in the spam log entry having the wrong spam trigger action. ie moderated vs denied.

Additionally logSpamTrigger skips logging on "accept" but, this doesn't match the API usage which can result in dropped logs.

Finally, it looks like logSpamTrigger will update the existing log entry (ie post gets...

Read more

Continue reading...
 
Status
Not open for further replies.

DMCA Content

Any DMCA takedown notice should be sent to this contact email: [email protected] We only respond and take action to plaintext e-mails. Do not send PDF or any other files.
Top